Skip to content

Doesn't compile - type mismatch #1

@coandco

Description

@coandco

Hi! I'm trying to use xcaddy to build caddy 2.8 on go 1.22.3 with the https://github.com/caddy-dns/dnsmadeeasy plugin, and it currently doesn't compile due to a type mismatch:

2024/05/30 12:19:16 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /home/coandco/caddy -ldflags -w -s -trimpath -tags nobadger
# github.com/libdns/dnsmadeeasy
/home/coandco/go/pkg/mod/github.com/libdns/dnsmadeeasy@v1.1.1/client.go:34:18: cannot use dmeRecord.MxLevel (variable of type int) as uint value in assignment
/home/coandco/go/pkg/mod/github.com/libdns/dnsmadeeasy@v1.1.1/client.go:36:18: cannot use dmeRecord.Priority (variable of type int) as uint value in assignment
/home/coandco/go/pkg/mod/github.com/libdns/dnsmadeeasy@v1.1.1/client.go:56:23: cannot use record.Priority (variable of type uint) as int value in assignment
/home/coandco/go/pkg/mod/github.com/libdns/dnsmadeeasy@v1.1.1/client.go:58:24: cannot use record.Priority (variable of type uint) as int value in assignment
2024/05/30 12:19:16 [INFO] Cleaning up temporary folder: /tmp/buildenv_2024-05-30-1219.1791603524
2024/05/30 12:19:16 [FATAL] exit status 1

It looks like the upstream libdns module may have updated the types of its libdns.Record type so that Priority and Weight are uints instead of ints, and so both recordFromDmeRecord and dmeRecordFromRecord fail to map the types across. It looks like either libdns/dnsmadeeasy needs to cast the types, or the upstream John-K/dnsmadeeasy needs to update its types to synchronize with libdns/libdns.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions