Don't die in volume() on a twisted element #3758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's probably a code smell that we've never seen a need for this before...
If someone is performing calculations here, a NaN rather than an exception is probably easier for them to deal with. If someone is using Elem::print_info() (perhaps to print information about a twisted element...) then a NaN rather than exception is *definitely* easier to deal with.
This is more consistent with what we get from our subclasses' volume() specializations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out by trying to return NaN when we detected a twisted element, but that was weirdly inconsistent between
Elem::volume()and it's various specializations, so instead I'm just returning the same "net volume" that we should be getting from the specializedvolume()functions when they're called on a twisted element. I'll leave the NaN stuff in our git history just in case we change our minds in the future; it would be tedious to detect twisted elements in every specialization, but not impossible.