Skip to content

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented Dec 23, 2023

they could trigger errors themselves

this was preventing a friend from looking at how many bad Jacobian elements they had.
And there were very many (1500), from a prism21 mesh generated in an external professional mesh generator. So this either means we have an error computing the Jacobian of prism21 elements in libmesh (I will tag the relevant people once holidays are past) or the mesh generation software can be made to create bad prism21s

refs #25278

@GiudGiud GiudGiud self-assigned this Dec 23, 2023
@moosebuild
Copy link
Contributor

Job Documentation on 688c1c9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@GiudGiud GiudGiud marked this pull request as ready for review December 24, 2023 00:41
@moosebuild
Copy link
Contributor

Job Coverage on 688c1c9 wanted to post the following:

Framework coverage

4d71af #26410 688c1c
Total Total +/- New
Rate 85.07% 85.07% +0.00% 100.00%
Hits 98385 98387 +2 7
Misses 17265 17265 - 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud GiudGiud merged commit 19c0e64 into idaholab:next Dec 28, 2023
@GiudGiud GiudGiud deleted the PR_no_double_excep branch December 28, 2023 20:34
@GiudGiud
Copy link
Contributor Author

Thanks for the review!

@roystgnr
Copy link
Contributor

roystgnr commented Jan 2, 2024

What's the stack trace on the errors from get_info()? Are we simply hitting failures when computing JxW in Elem::volume()? We probably ought to be doing that in a try/catch block, so we can return NaN rather than throw an error when the volume isn't well-defined...

IIRC I checked the ExodusII docs carefully when adding Prism21 import, but it's possible I made a mistake. Can you get me a minimal failing mesh?

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Jan 2, 2024

yes.
That works for me too. get_info was nice in that log, but what we have now is enough. I dont mind making another PR if libmesh changes get_info() to survive awful elements.

Sending to slack in 5

@roystgnr
Copy link
Contributor

roystgnr commented Jan 2, 2024

libMesh/libmesh#3758 should survive awful elements; at least it survives the particular awful element in the unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants