Skip to content

Conversation

@ModeSevenIndustrialSolutions
Copy link
Contributor

urllib3 2.6.1 released two days ago and contains important security fixes. SBOM/Grype audits (builds) have started failing in Python projects that need dependency updates. I've bumped all the Python dependencies for this project, and updated the uv.lock file. This update also includes fixes for failing tests during these updates. Since the Python build action recently got a new tagged/release, and includes the python-sigstore-action 3.2.0, Python 3.14 builds are working again.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Python dependencies to address security vulnerabilities, particularly upgrading urllib3 to 2.6.1 which contains important security fixes. The update also includes test improvements to isolate test git repositories from parent repository state and fix issues when running tests under pre-commit hooks.

Key Changes

  • Bumped urllib3 from 2.5.0 to 2.6.1 for security fixes
  • Removed Python 3.14 version constraint (was <3.14, now >=3.11)
  • Updated all Python dependencies to latest versions
  • Added --no-verify flag to git commits in tests to bypass hooks
  • Improved git environment isolation in tests by unsetting GIT_INDEX_FILE, GIT_DIR, and GIT_WORK_TREE
  • Fixed stderr handling in rich_display.py to ensure CliRunner captures error output

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
uv.lock Updated all Python dependencies including security-critical urllib3 2.6.1, plus certifi, charset-normalizer, click, coverage, cryptography, hatchling, iniconfig, mypy, pbr, pynacl, pytest, pyyaml, ruff, setuptools-scm, trove-classifiers, typer, and urllib3
pyproject.toml Removed Python 3.14 upper version constraint, updated minimum dependency versions, and reordered Python classifiers
tests/test_ssh_artifact_prevention.py Added environment variable isolation (GIT_INDEX_FILE, GIT_DIR, GIT_WORK_TREE) and --no-verify flag to git commits
tests/fixtures/make_repo.py Added environment variable isolation in _run_git and --no-verify flag to git commits
src/github2gerrit/rich_display.py Changed stderr handling to use typer.echo for better test capture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
@github-actions github-actions bot added the chore Code chores (dependency updates, etc) label Dec 10, 2025
@tykeal tykeal merged commit 003ce7a into lfreleng-actions:main Dec 10, 2025
18 checks passed
@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions deleted the python-deps branch January 30, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Code chores (dependency updates, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants