Fix processor usage in routes test #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideRefactors the routes test to instantiate and reuse a File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe test function in Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (3)
✨ Finishing Touches
🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @leynos - I've reviewed your changes - here's some feedback:
- Extract the LengthPrefixedProcessor::default() call into a single local variable and clone or reference it when configuring the app, encoding, and decoding to avoid repeating default instantiation.
- Consider moving the processor initialization into a small helper or fixture to reduce boilerplate and keep the test focused on routing logic rather than setup.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Extract the LengthPrefixedProcessor::default() call into a single local variable and clone or reference it when configuring the app, encoding, and decoding to avoid repeating default instantiation.
- Consider moving the processor initialization into a small helper or fixture to reduce boilerplate and keep the test focused on routing logic rather than setup.
## Individual Comments
### Comment 1
<location> `tests/routes.rs:52` </location>
<code_context>
- LengthPrefixedProcessor
- .encode(&env_bytes, &mut framed)
- .unwrap();
+ let processor = LengthPrefixedProcessor::default();
+ processor.encode(&env_bytes, &mut framed).unwrap();
</code_context>
<issue_to_address>
Consider reusing the processor instance throughout the test for consistency.
Reusing the same processor instance in all test steps, including .frame_processor, helps ensure consistency and can reveal state-related issues if the processor becomes stateful in the future.
Suggested implementation:
```rust
let processor = LengthPrefixedProcessor::default();
let app = app
.frame_processor(processor.clone())
.route(
1,
Box::new(move |_| {
};
let env_bytes = BincodeSerializer.serialize(&env).unwrap();
let mut framed = BytesMut::new();
processor.encode(&env_bytes, &mut framed).unwrap();
let out = run_app_with_frame(app, framed.to_vec()).await.unwrap();
let mut buf = BytesMut::from(&out[..]);
let frame = processor.decode(&mut buf).unwrap().unwrap();
let (resp_env, _) = BincodeSerializer
.deserialize::<TestEnvelope>(&frame)
.unwrap();
```
- Ensure that `LengthPrefixedProcessor` implements `Clone` if it does not already, as `.frame_processor(processor.clone())` requires it.
- If the `app` variable is not defined in this snippet, you may need to adjust the placement of the `processor` instantiation and the `.frame_processor()` call to fit the actual test structure.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| LengthPrefixedProcessor | ||
| .encode(&env_bytes, &mut framed) | ||
| .unwrap(); | ||
| let processor = LengthPrefixedProcessor::default(); |
There was a problem hiding this comment.
suggestion: Consider reusing the processor instance throughout the test for consistency.
Reusing the same processor instance in all test steps, including .frame_processor, helps ensure consistency and can reveal state-related issues if the processor becomes stateful in the future.
Suggested implementation:
let processor = LengthPrefixedProcessor::default();
let app = app
.frame_processor(processor.clone())
.route(
1,
Box::new(move |_| {
};
let env_bytes = BincodeSerializer.serialize(&env).unwrap();
let mut framed = BytesMut::new();
processor.encode(&env_bytes, &mut framed).unwrap();
let out = run_app_with_frame(app, framed.to_vec()).await.unwrap();
let mut buf = BytesMut::from(&out[..]);
let frame = processor.decode(&mut buf).unwrap().unwrap();
let (resp_env, _) = BincodeSerializer
.deserialize::<TestEnvelope>(&frame)
.unwrap();- Ensure that
LengthPrefixedProcessorimplementsCloneif it does not already, as.frame_processor(processor.clone())requires it. - If the
appvariable is not defined in this snippet, you may need to adjust the placement of theprocessorinstantiation and the.frame_processor()call to fit the actual test structure.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This was referenced Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LengthPrefixedProcessorinstead of the struct typeTesting
make fmtmake lintmake testhttps://chatgpt.com/codex/tasks/task_e_68558c3a2f608322bcf8739c022f97b1
Summary by Sourcery
Use a default-initialized LengthPrefixedProcessor instance for route configuration and test framing instead of referring to the struct type directly
Tests:
default()for encode/decode operationsLengthPrefixedProcessor::default()instance toframe_processorin app setup instead of the struct typeSummary by CodeRabbit