Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add array to dotStyles propTypes #598

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Conversation

yomybaby
Copy link
Contributor

@yomybaby yomybaby commented Oct 4, 2017

Is it a bugfix ?

  • Yes

Is it a new feature ?

  • No

Describe what you've done:

style can be array.

How to test it ?

set dotStyles using array

<Swiper 
  dotStyle={styles.scrollDotStyle}
  activeDotStyle={[styles.scrollDotStyle,{ backgroundColor: '#686868'}]}>

@hbarylskyi
Copy link

I see yellow warning message about activeDotStyles propTypes every time I open the app. Would be cool if this was merged

@ArrayZoneYour ArrayZoneYour merged commit 7ebd74d into leecade:master Jun 27, 2019
pandamako added a commit to Complead/react-native-swiper that referenced this pull request Dec 24, 2019
* upstream/master: (31 commits)
  Pass State Types to Swiper Component (leecade#1076)
  Add missing scrollTo TypeScript definition (leecade#1036)
  feat(vertical): partical support vertical scrolling (leecade#1017)
  fix(children): fix the crash when only one children (leecade#1016)
  chore(package): update standard to version 13.0.1 (leecade#1014)
  fix(types): allow the style to be array (leecade#1013)
  docs(nightly): add nightly version updates (leecade#1012)
  feat(pages): support optionally render page (leecade#1009)
  Bump handlebars from 4.0.10 to 4.1.2 in /examples
  Bump stringstream from 0.0.5 to 0.0.6 in /examples (leecade#994)
  add array to dotStyles propTypes (leecade#598)
  Bump diff from 3.3.0 to 3.5.0 in /examples (leecade#990)
  chore(package): update snazzy to version 7.1.0 (leecade#736)
  chore(package): update standard to version 11.0.0 (leecade#733)
  Added prop to disable the PrevButton (leecade#749)
  fix(autoplay): replay when autoplay is setted to true
  Remove Arial font style
  fix(types): correct the wrong types
  docs(readme): remove ad
  docs(v1.6.0-dev): update changelog and installation guide
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants