Pass State Types to Swiper Component #1076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it a bugfix ?
Is it a new feature ?
Describe what you've done:
In trying to do something along the lines of:
TypeScript was saying "Property 'index' does not exist on type 'Readonly<{}>'." on
swiper.current.state.index
, even though the value was defined at runtime and these values appeared to be defined in state in the component's source code.In looking at the types, it looked like the state wasn't being passed to the
React.Component
type, so it made sense that TS believed that the state object was empty. Applying this change resolves that.How to test it ?
I've tested it in my project. I imagine anything that tries to pull state off of a ref will encounter this issue. Happy to try to put together a quick test project if that would be useful.
Thank you for your work on this project, please let me know if I there's anything I can do to improve this PR!