Apply grade_levels tags styling to category metadata tags #5128
Conversation
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Hi @LianaHarris360, thank you. Code looks good to me overall.
Before I preview - updated experience looks much better to me from the screenshots, just want to make sure that this is okay with designers? Was there a previous conversation?
| >{{ subtitle }}</span> | ||
| <span | ||
| v-if="node.categories ? Object.keys(node.categories).length > 0 : null" | ||
| class="text" |
There was a problem hiding this comment.
I don't see text class being used from anywhere now, can be removed from <styles>
There was a problem hiding this comment.
The subtitle above uses the text class as well :)
akolson
left a comment
akolson
left a comment
There was a problem hiding this comment.
Code changes look correct to me. I was however unable to run the branch locally although I think this is not related any changes you have made (I'll cross-check with unstable). So merging this pr should be fine after incorporating Misha's feedback. Thanks @LianaHarris360
|
That's fine @LianaHarris360, I thought there might be some hidden Slack threads :) |
3 participants
Summary
This pull request updates the styling of the metadata category tags to ensure visual consistency and enhance their styling, so that it is easier to more quickly identify when category tags have been successfully updated during bulk editing.
Before:
After:
References
Fixes #5042
Reviewer guidance
Ensure that the category tags have the same visual styling as the grade level tags and that there are no regressions when updating the category tags.