Skip to content

Comments

Ensure that file_format and preset match during file_upload requests.#5040

Merged
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:matchy_matchy
Aug 13, 2025
Merged

Ensure that file_format and preset match during file_upload requests.#5040
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:matchy_matchy

Conversation

@rtibbles
Copy link
Member

@rtibbles rtibbles commented May 1, 2025

Summary

  • Adds a small validation check to file uploads to ensure that we don't allow uploads of files with mismatched file formats and format presets
  • Adds/updates tests for the same

@rtibbles rtibbles mentioned this pull request May 1, 2025
Closed
bjester
bjester approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit c332afa into learningequality:unstable Aug 13, 2025
13 checks passed
@bjester bjester mentioned this pull request Aug 14, 2025
Merged
@bjester bjester mentioned this pull request Aug 22, 2025
Merged
@rtibbles rtibbles deleted the matchy_matchy branch September 25, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjester bjester bjester approved these changes

Assignees

@ozer550 ozer550

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rtibbles @bjester @ozer550