Fix various file upload validation omissions#5025
Closed
rtibbles wants to merge 4 commits intolearningequality:unstablefrom
Closed
Fix various file upload validation omissions#5025rtibbles wants to merge 4 commits intolearningequality:unstablefrom
rtibbles wants to merge 4 commits intolearningequality:unstablefrom
Conversation
…esets in add_nodes.
Member
Author
|
Looking at this again, I think the changes here in the file upload URL handling are good - but something a bit more robust would be better for the internal endpoints. I think the simplest solution is to create DRF serializers for the internal endpoints to provide proper input sanitization and validation. |
Member
Author
|
Closing for now in favour of #5040 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #5022
Reviewer guidance
Do the changes make sense? Are they covered by tests? What might this now be allowing or disallowing that might cause issues I haven't anticipated?