Proper colors on selected-indeterminate and non-selected in clipboard#4691
Merged
akolson merged 1 commit intolearningequality:unstablefrom Sep 12, 2024
Conversation
AlexVelezLl
reviewed
Aug 29, 2024
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Code changes makes sense to me, and manual QA suggest everything is working fine. Thank you @nucleogenesis! I think the only thing left to do is to update the KDS version once the new version has been released =)
Merged
de2efaa to
8c717d0
Compare
AlexVelezLl
approved these changes
Sep 11, 2024
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
LGTM! Thanks @nucleogenesis
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Screenshots (if applicable)
2024-08-29.12-46-25.mp4
Does this introduce any tech-debt items
/deep/selectors are hacky and if we need this pattern again in the future, it will need to handle this directly.Reviewer guidance
How can a reviewer test these changes?
How's the screencast look?
This PR does not include it, but to test this locally you need to point your
package.jsonentry for KDS to use this PR in KDS.References
Closes #4636
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)