Merged
Conversation
…ription Quick edit modal for content title and description
Add new kebab menu items and refactor structure for quick edit modals
bjester
reviewed
Mar 14, 2024
Member
There was a problem hiding this comment.
Overall, it's looking good. I'm wondering if it's worth deduping some of 'Save' / 'Cancel' strings. I think we have some mixins that might have the strings? We did have a retrospective last year and decided on an approach for reusing strings but I can't quite recall what we decided.
I'll give it a test drive soon!
contentcuration/contentcuration/frontend/channelEdit/components/ContentNodeOptions.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/ContentNodeEditListItem.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/ContentNodeOptions.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/ContentNodeOptions.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/ContentNodeOptions.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/utils/helpers.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/LicenseDropdown.vue
Show resolved
Hide resolved
...ntentcuration/frontend/shared/views/contentNodeFields/CompletionOptions/ActivityDuration.vue
Show resolved
Hide resolved
Fix two parallel content nodes editing logic
Member
|
I ran into this bug, both in |
contentcuration/contentcuration/frontend/shared/views/AboutLicensesModal.vue
Show resolved
Hide resolved
386bff4 to
4dcc60d
Compare
akolson
approved these changes
Aug 14, 2024
Member
There was a problem hiding this comment.
Approving this and proceeding with the merge into unstable. Great work on this @AlexVelezLl 🎉 . cc @marcellamaki
Member
|
🎉🎉🎉 |
Merged
24 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This PR introduces the new Studio Usabiliy enhancements project:
We now allow quick editing of the following fields of one or more resources and folders:
And editing the following fields of one or more resources:
Bulk editing of folder descendants, so that if the user is editing any field in a folder, they can choose to replicate the change to all of its descendants.
New command palette arrangement, with responsive design.
Screenshots (if applicable)
Editing single resources:
Compartir.pantalla.-.2024-03-01.09_03_50.mp4
Editing multiple resources and topics:
Compartir.pantalla.-.2024-03-01.09_06_15.mp4
Does this introduce any tech-debt items?
A drawback is that we are now having two parallel editing logic for some of the fields which can be a problem in the future.
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Addresses #3412
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)