Add new kebab menu items and refactor structure for quick edit modals#4368
Conversation
There was a problem hiding this comment.
Generally the code in this file looks good. However, the code is beginning to look repetitive(particularly the options--<VListTile>s) and this may not be good for maintenance. A possible way to deal with the repetition would be to introduce an options data array and use a for loop to create the options.(This is not a blocker, but its worth considering)
akolson
left a comment
There was a problem hiding this comment.
Hi @AlexVelezLl ! Code generally looks good. Just a few thoughts on how we could improve the way we generate the options, but this is not a blocker 🙂
|
Thanks! @akolson I have just updated the PR with the refactored code including a new "groupedOptions" computed property to dynamically render the options of the menu! I will merge this PR since this is a blocker for other PRs but we can update this approach later if needed! |
Summary
Description of the change(s) you made
Note: I was stuck on making the menu keyboard-accessible due to some issues with the way Vuetify handles menus. So I opened a follow up issue for this.
Screenshots (if applicable)
Menu on large screens

Menu on smaller screens

References
Addresses #3414
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)