Skip to content

Update webpack for proper RTL build, using a placeholder module #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 2 commits into from
Jun 5, 2023
Merged

Update webpack for proper RTL build, using a placeholder module #4106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72de2db
Update webpack for proper RTL build, using a placeholder module
marcellamaki Jun 2, 2023
36ea352
Move location of placeholder file. add explanatory comments about pla…
marcellamaki Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions contentcuration/contentcuration/frontend/shared/styles/modulePlaceholder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// This file is used as a placeholder, following the same pattern established in
// jest_config/globalMocks/fileMock.js

// It is used to help use properly overwrite the vuetify stylus files using webpack
// (see also webpack.config.js > webpack.NormalModuleReplacementPlugin())

'module-file-stub';
9 changes: 6 additions & 3 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const webpack = require('webpack');
const djangoProjectDir = path.resolve('contentcuration');
const staticFilesDir = path.resolve(djangoProjectDir, 'contentcuration', 'static');
const srcDir = path.resolve(djangoProjectDir, 'contentcuration', 'frontend');
const dummyModule = path.resolve(srcDir, 'shared', 'styles', 'modulePlaceholder.js')

const bundleOutputDir = path.resolve(staticFilesDir, 'studio');

Expand All @@ -42,6 +43,7 @@ module.exports = (env = {}) => {
exclude: dev ? [/./] : [/\.map$/, /^manifest.*\.js$/]
});


if (dev) {
// Suppress the "InjectManifest has been called multiple times" warning by reaching into
// the private properties of the plugin and making sure it never ends up in the state
Expand Down Expand Up @@ -115,9 +117,10 @@ module.exports = (env = {}) => {
modules: [rootNodeModules],
},
plugins: [
new webpack.IgnorePlugin({
resourceRegExp: /\.\.\/stylus\//,
}),
new webpack.NormalModuleReplacementPlugin(
/vuetify\/src\/stylus\//,
dummyModule
),
new BundleTracker({
filename: path.resolve(djangoProjectDir, 'build', 'webpack-stats.json'),
}),
Expand Down