Update webpack for proper RTL build, using a placeholder module#4106
Merged
rtibbles merged 2 commits intolearningequality:hotfixesfrom Jun 5, 2023
Merged
Update webpack for proper RTL build, using a placeholder module#4106rtibbles merged 2 commits intolearningequality:hotfixesfrom
rtibbles merged 2 commits intolearningequality:hotfixesfrom
Conversation
…ceholder file purpose
rtibbles
approved these changes
Jun 5, 2023
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Makes an update to webpack to ensure that the /vuetify/src/stylus is properly overridden.
Manual verification steps performed
Run a local version of the production environment - seems to work!
Screenshots (if applicable)
rtl-fix.mp4
Reviewer guidance
How can a reviewer test these changes?
using Arabic
References
Fixes reopened #3499
Comments
The random empty placeholder file is 1) in a weird place and 2).... kind of confusing? I just don't know a logical place to move it but can do so and update the path.
(Also, since I will be out Friday, reviewer(s) pushing a change to this directly is 1000% fine with me)
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)