Adds capability to ricecooker endpoints to specify an existing node for which the ricecooker user has permissions to copy into tree#4050
Merged
bjester merged 2 commits intolearningequality:unstablefrom May 11, 2023
Conversation
rtibbles
force-pushed
the
i_think_im_a_clone_now
branch
from
b108353 to
e6886bc
Compare
bjester
approved these changes
May 10, 2023
| "suggested_duration", | ||
| } | ||
|
|
||
| EDIT_ALLOWED_OVERRIDES = ALLOWED_OVERRIDES.union({ |
Member
There was a problem hiding this comment.
With these 3 words all in the variable name, the variable's purpose took me a moment to decipher (thinking 'overrides' already feels like an 'edit'). Not sure if EDITOR makes it clearer?
Member
Author
There was a problem hiding this comment.
Yeah, I was not at the race for my variable naming this day. EDITOR does make a bit more sense, definitely.
| """ | ||
|
|
||
| def _make_node_data(self): | ||
| random_data = mixer.blend(SampleContentNodeDataSchema) |
Member
There was a problem hiding this comment.
Nice! I haven't seen this before
Member
Author
There was a problem hiding this comment.
Hah, I copied this from elsewhere in the same file - so I can take 0 credit :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed