Skip to content

Rollback late acknowledgement and configure visibility timeout #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 2 commits into from
Jun 28, 2022
Merged

Rollback late acknowledgement and configure visibility timeout #3435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6995c30
Rollback late acknowledgement until we upgrade celery
bjester Jun 28, 2022
59773a3
Increase visibility timeout from 1 hr to 4 hrs
bjester Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contentcuration/contentcuration/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,8 @@ def gettext(s):

# CELERY CONFIGURATIONS
CELERY_BROKER_URL = REDIS_URL
# with a redis broker, tasks will be re-sent if not completed within the duration of this timeout
CELERY_BROKER_TRANSPORT_OPTIONS = {'visibility_timeout': 4 * 3600}
CELERY_RESULT_BACKEND = REDIS_URL
CELERY_REDIS_DB = os.getenv("CELERY_REDIS_DB") or "0"
CELERY_BROKER_URL = "{url}{db}".format(
Expand Down
4 changes: 2 additions & 2 deletions contentcuration/contentcuration/utils/celery/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ def my_task(self):
track_progress = False

# ensure our tasks are restarted if they're interrupted
acks_late = True
acks_on_failure_or_timeout = True
acks_late = False
acks_on_failure_or_timeout = False
reject_on_worker_lost = True

_progress_tracker = None
Expand Down