Merged
Conversation
rtibblesbot
approved these changes
Mar 31, 2026
Contributor
rtibblesbot
left a comment
There was a problem hiding this comment.
Dependency Update Review
Package: dompurify 3.3.2 → 3.3.3
Semver risk: Patch
Dependency type: Production
CI status: Passing
Changelog Analysis
Sources consulted:
Breaking changes: None.
Security fixes: None.
Notable changes:
- Fixed an overly strict Node.js engine requirement that caused installation issues in some environments (PR #1210). The
enginesfield was relaxed since the published package contains finished builds with no direct Node version requirement. - Internal-only changes: dev dependency updates, test infrastructure maintenance (QUnit, jsdom), README updates.
Compatibility Assessment
- Project uses affected APIs: No — this is a packaging metadata fix, not an API change.
- Peer dependency changes: None.
- Code changes required: None.
- Lockfile: dompurify bump plus normal transitive resolution changes (
@babel/core7.28.6 → 7.29.0 from lock regeneration). No unexpected additions.
Recommendation
APPROVE — Minimal-risk patch release fixing only a Node engine constraint. No API or behavioral changes. CI passing.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Reviewed the pull request diff checking for:
- Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
- Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
- Architecture: duplicated concerns, minimal interfaces, composition over inheritance
- Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
- Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
- Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
- Checked CI status and linked issue acceptance criteria
- For UI changes: inspected screenshots for layout, visual completeness, and consistency
Contributor
Build Artifacts
Smoke test screenshot |
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.3.2 to 3.3.3. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.3.2...3.3.3) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.3.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
ecd1576 to
bc3030b
Compare
rtibbles
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dompurify from 3.3.2 to 3.3.3.
Release notes
Sourced from dompurify's releases.
Commits
8bcbf73chore: Preparing 3.3.3 release5faddd6fix: engine requirement (#1210)0f91e3aUpdate README.mdd5ff1a8Merge branch 'main' of github.com:cure53/DOMPurifyc3efd48fix: moved back from jsdom 28 to jsdom 20988b888fix: moved back from jsdom 28 to jsdom 202726c74chore: Preparing 3.3.2 release6202c7ebuild(deps): bump@tootallnate/onceand jsdom (#1204)302b51dfix: Expanded the regex ever so slightly to also cover scriptcd85175Merge branch 'main' of github.com:cure53/DOMPurify