Merged
Conversation
The package is used to distribute finished builds that do not have any direct requirements for the node version used. However, a modern nodejs environment is required for the build process. A different configuration is provided for this purpose: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#devengines
There was a problem hiding this comment.
Pull request overview
This PR adjusts Node.js version requirements so consumers installing the published package aren’t blocked by a Node engine constraint, while still declaring a modern Node requirement for development/build workflows (per the devEngines approach referenced in the PR description).
Changes:
- Replaced
engines.node >=20with adevEnginesconfiguration intended to warn (not fail) when the dev/runtime Node version is outdated. - Removed the root package
enginesentry frompackage-lock.jsonto match the updatedpackage.json.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Moves the Node version requirement from install-time (engines) to dev/build-time (devEngines) with warn behavior. |
| package-lock.json | Removes the root engines metadata to reflect the package.json change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thank you very much 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enginesrequirements causes problems.Background & Context
The package is used to distribute finished builds that do not have any direct requirements for the node version used.
However, a modern nodejs environment is required for the build process. A different configuration is provided for this purpose: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#devengines
Tasks
Dependencies
fixes #1209