Skip to content

fix: engine requirement#1210

Merged
cure53 merged 1 commit intocure53:mainfrom
Rotzbua:fix_engine
Mar 9, 2026
Merged

fix: engine requirement#1210
cure53 merged 1 commit intocure53:mainfrom
Rotzbua:fix_engine

Conversation

@Rotzbua
Copy link
Copy Markdown
Contributor

@Rotzbua Rotzbua commented Mar 9, 2026

Summary

engines requirements causes problems.

Background & Context

The package is used to distribute finished builds that do not have any direct requirements for the node version used.

However, a modern nodejs environment is required for the build process. A different configuration is provided for this purpose: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#devengines

Tasks

  • CI should go green
  • thows warnings on outdated node versions if try to build
  • no warning on other installs

Dependencies

fixes #1209

The package is used to distribute finished builds that do not have any direct requirements for the node version used.
However, a modern nodejs environment is required for the build process. A different configuration is provided for this purpose:
https://docs.npmjs.com/cli/v11/configuring-npm/package-json#devengines
Copilot AI review requested due to automatic review settings March 9, 2026 03:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts Node.js version requirements so consumers installing the published package aren’t blocked by a Node engine constraint, while still declaring a modern Node requirement for development/build workflows (per the devEngines approach referenced in the PR description).

Changes:

  • Replaced engines.node >=20 with a devEngines configuration intended to warn (not fail) when the dev/runtime Node version is outdated.
  • Removed the root package engines entry from package-lock.json to match the updated package.json.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Moves the Node version requirement from install-time (engines) to dev/build-time (devEngines) with warn behavior.
package-lock.json Removes the root engines metadata to reflect the package.json change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cure53 cure53 merged commit 5faddd6 into cure53:main Mar 9, 2026
9 of 10 checks passed
@cure53
Copy link
Copy Markdown
Owner

cure53 commented Mar 9, 2026

Thank you very much 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

version 3.3.2 is a breaking change

3 participants