Remote connection status#10347
Merged
rtibbles merged 8 commits intolearningequality:developfrom Mar 31, 2023
Merged
Conversation
Contributor
Build Artifacts
|
d89d276 to
9dad814
Compare
added 7 commits
March 31, 2023 09:32
fcc2c10 to
27c8929
Compare
27c8929 to
9d2ade1
Compare
Closed
9 tasks
Member
marcellamaki
left a comment
There was a problem hiding this comment.
This looks good to me and initial manual QA checks out. @radinamatic can @pcenov confirm this Monday morning his time?
akolson
reviewed
Mar 31, 2023
| </div> | ||
| </template> | ||
| </CoreMenu> | ||
| <DeviceConnectionStatus :deviceId="deviceId" /> |
Member
There was a problem hiding this comment.
Non-blocking, but just double checking you intentionally left out the color prop here :)
Member
|
Hi @jredrejo, I have some questions because while I am able to see the 'Disconnected' status icon as shown in your example I am also observing the following issues and it's not clear to me whether these are in scope of this PR or are separate issues:
Video: 2023-04-03_13-16-00.mp4 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a connection status icon when browsing a remote library content

References
Closes: #9859
Reviewer guidance
As in the attached video, explore a remote library and connect and disconnect the remote device to test if it works fine.
Testing checklist
PR process
Reviewer checklist
yarnandpip)