Skip to content

feat(Algebra/Category): P.Under ⊤ R has finite limits if P is stable under finite products and equalizers#36919

Open
chrisflav wants to merge 10 commits intoleanprover-community:masterfrom
chrisflav:under-limits-ring
Open

feat(Algebra/Category): P.Under ⊤ R has finite limits if P is stable under finite products and equalizers#36919
chrisflav wants to merge 10 commits intoleanprover-community:masterfrom
chrisflav:under-limits-ring

Conversation

@chrisflav chrisflav added t-category-theory Category theory WIP Work in progress labels Mar 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

PR summary a090f46da7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
4 files Mathlib.Algebra.Category.CommAlgCat.FiniteType Mathlib.CategoryTheory.Comma.Over.StrictInitial Mathlib.CategoryTheory.MorphismProperty.Comma Mathlib.CategoryTheory.MorphismProperty.OverAdjunction
1
Mathlib.Algebra.Category.Ring.Under.Property (new file) 2664

Declarations diff

+ CreatesFiniteProducts.mk'
+ HasEqualizers
+ HasFiniteProducts
+ StructuredArrow.closedUnderColimitsOfShape_discrete_empty
+ StructuredArrow.isClosedUnderLimitsOfShape
+ Under.closedUnderColimitsOfShape_discrete_empty
+ Under.closedUnderColimitsOfShape_pushout
+ Under.createsEqualizersForget
+ Under.createsFiniteLimitsForget
+ Under.createsFiniteProductsForget
+ Under.hasEqualizers
+ Under.hasFiniteLimits
+ Under.hasFiniteProducts
+ Under.property_limit_of_hasFiniteProducts_of_hasEqualizers
+ createsLimitsOfShape_walkingCospan
+ instance (priority := 900) [HasPushouts T] [P.IsStableUnderComposition]
+ instance : CreatesFiniteColimits (Under.forget P ⊤ X)
+ instance : PreservesFiniteColimits (Under.forget P ⊤ X)
+ instance [HasFiniteWidePushouts T] : HasFiniteColimits (P.Under ⊤ X)
+ instance [P.ContainsIdentities] (Y : P.Under ⊤ X) :
+ instance [P.ContainsIdentities] : HasInitial (P.Under ⊤ X)
+ instance [P.ContainsIdentities] [P.RespectsIso] :
+ inverseImage_op_overObj
+ inverseImage_op_underObj
+ mkIdInitial
+ structuredArrow_iso_iff
+ under_iso_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (6.00, 0.00)
Current number Change Type
6519 6 backward.isDefEq.respectTransparency

Current commit cdd5d3e41d
Reference commit a090f46da7

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Mar 20, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 1, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 9, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 9, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 13, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Apr 13, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-category-theory Category theory WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant