Skip to content

[Merged by Bors] - chore(CategoryTheory/Limits): functoriality of coconeLeftOpOfCone and co#36918

Closed
chrisflav wants to merge 1 commit intoleanprover-community:masterfrom
chrisflav:cone-op-equivs
Closed

[Merged by Bors] - chore(CategoryTheory/Limits): functoriality of coconeLeftOpOfCone and co#36918
chrisflav wants to merge 1 commit intoleanprover-community:masterfrom
chrisflav:cone-op-equivs

Conversation

@chrisflav
Copy link
Copy Markdown
Member


Open in Gitpod

@chrisflav chrisflav added the t-category-theory Category theory label Mar 20, 2026
@github-actions
Copy link
Copy Markdown

PR summary f2fa93365e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coconeLeftOpOfConeEquiv
+ coconeRightOpOfConeEquiv
+ coconeUnopOfConeEquiv
+ coneLeftOpOfCoconeEquiv
+ coneOpEquiv
+ coneRightOpOfCoconeEquiv
+ coneUnopOfCoconeEquiv

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 23, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 23, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory/Limits): functoriality of coconeLeftOpOfCone and co [Merged by Bors] - chore(CategoryTheory/Limits): functoriality of coconeLeftOpOfCone and co Mar 23, 2026
@mathlib-bors mathlib-bors bot closed this Mar 23, 2026

/-- Cones on `F : J ⥤ C` are equivalent to cocones on `F.op : Jᵒᵖ ⥤ Cᵒᵖ`. -/
@[simps]
def coneOpEquiv {F : J ⥤ C} : (Cone F)ᵒᵖ ≌ Cocone F.op where
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I noticed that coneOpEquiv is essentially the same as (the dual of) coconeEquivalenceOpConeOp. Do we really need both? And can the names be made more similar?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we need both because F.op.op is sadly not def-eq to F :) I agree that the names should be more similar and the statements aligned (adapting the style of coneOpEquiv).

justus-springer pushed a commit to justus-springer/mathlib4 that referenced this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants