Remove existing examples from registries and coded_tools #32
+9
−8,065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepsaia
commented
Apr 30, 2025
Comment on lines
+20
to
+21
| registries/ | ||
| coded_tools/ |
There was a problem hiding this comment.
Add registries and coded_tools to gitignore and let users to use them locally
Comment on lines
+58
to
+60
| - Ensure that you have a few example hocon files in your `registries` and the same mapped in `registries/manifest`. | ||
| - [Optional] Ensure that you have the necessary coded tools in the `coded_tools` dir. | ||
|
|
There was a problem hiding this comment.
Add some context in readme
There was a problem hiding this comment.
When used from neuro-san-demos that's not necessary.
It's only for people running directly from the nsflow repo. In that case we could use the manifest and hocon files that are shipped with the neuro-san library.
Subject for another PR.
ofrancon
approved these changes
May 1, 2025
Comment on lines
+58
to
+60
| - Ensure that you have a few example hocon files in your `registries` and the same mapped in `registries/manifest`. | ||
| - [Optional] Ensure that you have the necessary coded tools in the `coded_tools` dir. | ||
|
|
There was a problem hiding this comment.
When used from neuro-san-demos that's not necessary.
It's only for people running directly from the nsflow repo. In that case we could use the manifest and hocon files that are shipped with the neuro-san library.
Subject for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
registriesandcoded_tools