RISCV: Backport some upstream changes #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on dlang#8477, dlang#8478, and dlang#8479. Also adjust the order of some version conditions in std/math/hardware.d to allow compilation using a RISCV64 port of LDC.
| version (LDC) | ||
| version (RISCV_Any) | ||
| { | ||
| mixin(` |
There was a problem hiding this comment.
Thanks for your review. I'm not so sure why the previous implementation uses mixin. All I've done is moving this RISCV_Any condition above the LDC condition. It was first committed in dlang@3d84369.
There was a problem hiding this comment.
IIRC, that was a problem of the dscanner linter not supporting GDC-style inline asm...
There was a problem hiding this comment.
ah ok. Well it's OK. Refactoring is usually better done separately :)
kinke
added a commit
that referenced
this pull request
Feb 26, 2023
The missing relevant pieces from #71.
kinke
added a commit
to kinke/ldc
that referenced
this pull request
Feb 26, 2023
The missing relevant pieces from ldc-developers/phobos#71.
kinke
added a commit
to ldc-developers/ldc
that referenced
this pull request
Feb 26, 2023
The missing relevant pieces from ldc-developers/phobos#71.
|
I've added the missing LDC-specific asm blocks; the other stuff had already been added (I haven't checked the unittests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on dlang#8477,
dlang#8478, and
dlang#8479.
Also adjust the order of some version conditions in std/math/hardware.d
to allow compilation using a RISCV64 port of LDC.