Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RISCV: Fix wrong ExceptionMask values #8477

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

Ast-x64
Copy link
Contributor

@Ast-x64 Ast-x64 commented Jun 16, 2022

According to RISCV specifications
https://riscv.org/wp-content/uploads/2019/12/riscv-spec-20191213.pdf,
figure 11.2, the mask flags should be NX, UF, OF, DZ, NV in order.

According to RISCV specifications
https://riscv.org/wp-content/uploads/2019/12/riscv-spec-20191213.pdf,
figure 11.2, the mask flags should be NX, UF, OF, DZ, NV in order.
@Ast-x64 Ast-x64 requested a review from ibuclaw as a code owner June 16, 2022 16:38
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Ast-x64! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8477"

@dlang-bot dlang-bot merged commit 0c56468 into dlang:master Jun 16, 2022
Ast-x64 added a commit to Ast-x64/phobos that referenced this pull request Jun 28, 2022
Based on dlang#8477,
dlang#8478, and
dlang#8479.
Also adjust the order of some version conditions in std/math/hardware.d
to allow compilation using a RISCV64 port of LDC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants