Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@dkgroot
Copy link

@dkgroot dkgroot commented Dec 21, 2017

@joakim-noah
Copy link

Go ahead and update this to the latest version that got merged upstream and I'll pull it.

@dkgroot dkgroot force-pushed the ldc-ltsmaster_posix branch 2 times, most recently from 7e48091 to d06a232 Compare February 22, 2018 12:49
@dkgroot
Copy link
Author

dkgroot commented Feb 22, 2018

@joakim-noah : Rebase and synced with dlang/PR/2001
Ready to Merge
DFly SemaphoreCI

Copy link

@joakim-noah joakim-noah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions.


enum PTHREAD_MUTEX_INITIALIZER = null;
//enum PTHREAD_ONCE_INIT = { PTHREAD_NEEDS_INIT, NULL };
enum PTHREAD_ONCE_INIT = pthread_once_t.init;;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete one semi-colon, missed this upstream too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

PTHREAD_MUTEX_ERRORCHECK = 1,
PTHREAD_MUTEX_RECURSIVE = 2,
PTHREAD_MUTEX_NORMAL = 3,
PTHREAD_MUTEX_ADAPTIVE_NP = 4,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't there upstream.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed PTHREAD_MUTEX_ADAPTIVE_NP = 4,
Thanks !

int shmdt(in void*);
int shmget(key_t, size_t, int);
}
else version( DragonFlyBSD )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither is this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh... but it should be (will amend dlang/druntime). Thanks for noticing this one !

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dlang#2106 has been approved => waiting to be merged

@dkgroot dkgroot force-pushed the ldc-ltsmaster_posix branch from 82fad9e to 1b7484d Compare February 23, 2018 18:40
@dkgroot dkgroot force-pushed the ldc-ltsmaster_posix branch from 675f9b3 to 371046a Compare February 23, 2018 19:27
@joakim-noah joakim-noah merged commit 6a35484 into ldc-developers:ldc-ltsmaster Mar 4, 2018
@dkgroot
Copy link
Author

dkgroot commented Mar 4, 2018

@joakim-noah Thanks for review and merging !

@dkgroot dkgroot deleted the ldc-ltsmaster_posix branch March 4, 2018 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants