Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@dkgroot
Copy link
Contributor

@dkgroot dkgroot commented Dec 21, 2017

@joakim-noah
Copy link
Contributor

I see that you've submitted a version of this upstream also. I suggest you limit this pull to only changes you didn't need upstream, which should be easy since it's so small.

@dkgroot
Copy link
Contributor Author

dkgroot commented Jan 3, 2018

@joakim-noah Is it ok for me to leave them a little longer (until the dmd pr is accepted). That way i can run all the unittests smoothly.

@joakim-noah
Copy link
Contributor

Yep, no problem, just saying what will be needed then.

@dkgroot
Copy link
Contributor Author

dkgroot commented Feb 12, 2018

@joakim-noah Everything is finally merged in (dlang) dmd, druntime and phobos (Also in part thanks to you). Now I need to figure out what needs to be backported here.

@joakim-noah
Copy link
Contributor

I'll do it, just let me know if I miss anything.

@joakim-noah
Copy link
Contributor

I don't really want to do it. 😝 Go ahead and update this patch to what you got merged upstream and is necessary for this branch, and I'll pull it.

@joakim-noah
Copy link
Contributor

Only DragonFly PR left, would be good to get this in before the 0.17.6 release.

@dkgroot dkgroot force-pushed the dragonfly-ltsmaster branch from a93ece5 to b85d5d7 Compare March 7, 2018 11:31
@dkgroot
Copy link
Contributor Author

dkgroot commented Mar 7, 2018

@joakim-noah
The Makefile needed touching up (to match the dlang/dmd/test/Makefile one). The other two changes already matched.
Thanks for merging the other PR's and helping out on this one !

@joakim-noah joakim-noah merged commit cc17194 into ldc-developers:ldc-ltsmaster Mar 7, 2018
@dkgroot
Copy link
Contributor Author

dkgroot commented Mar 7, 2018

Thanks a lot !!

@dkgroot dkgroot deleted the dragonfly-ltsmaster branch March 7, 2018 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants