Skip to content

Added homogeneous 2D mesh; added tests of 1D and homogeneous 2D geo. #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 24, 2023

Conversation

drobnyjt
Copy link
Collaborator

  • Opened an issue
  • Referenced the relevant issue number(s) below
  • Provided a description of the changes below
  • Ensured all tests pass and added any necessary tests for new code

Fixes #206, #210

Description

Adds a Homogeneous 2D mesh option.

Tests

Added geometry tests for the new geometry type; tests run succesfully.

@drobnyjt
Copy link
Collaborator Author

drobnyjt commented May 24, 2023

Straight transposition of the boron nitride wire example errors out at the closest point routine; needs further investigation.

Edit: The cause of the issue seems to be when a point (x, y) is exactly on a vertex of a Polygon. Unsure of robust fix currently; will have to check geo library for options.

Edit 2: This has been fixed - an additional arm to cover the IntersectionPoint enum value had to be added. This has been addressed throughout the code where relevant, which might have been the cause of an exceptionally rare (only seen in simulations with N>1E7) bug I'd observed where, very occasionally, the code would panic with a geometry error.

@drobnyjt drobnyjt merged commit 4d26e3d into dev May 24, 2023
@drobnyjt drobnyjt deleted the add_homogeneous_2d_mesh branch May 24, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant