Use modular cloudwatch package instead of entire aws sdk. #172
Conversation
|
First of all thanls for this! I will review as soon as I can, I have close to zero time now but your effort means a lot to me. |
It's my pleasure, and no worries! Yes, I'm currently using it in a staging environment. It seems to work, but I've only used it very lightly for a half hour or so. I saw somebody post an issue addressing this same issue and their solution as well, they mentioned that there was a change from |
|
Can you reference that issue here please? |
|
Yes, here it is: #160 (comment) |
|
+1 |
|
Im using @peakyDicers solution and it works. Im using it on staging and production environment, and I didnt encounter problems so far. |
|
Thanks for the feedback and the effort! Sorry for being so late I am swamped with work and uni study. winston-cloudwatch@3.2.0 is out. |
|
Heads up. This PR broke the ability to set aws credentials in CloudwatchTransportOptions. 3.1.1 is the last working version. |
|
Thanks @tkdave; if you have a solution for this issue feel free to send a PR, otherwise I will see if I can have a look in the next days, as it is a long standing issue. |
proxy-agent was made redundant after #172, which introduced v3 of aws-sdk. This meant that any proxy-related config was done on the `AWS.CloudwatchLogs` instance, rather than on `WinstonCloudwatch` Removing this dependency avoids a critical vulnerability with vm2, inherited via proxy-agent and its dependencies. Fixes #218 Supersedes #216
I wanted to use aws' new modular packages instead of the full aws sdk.
I made it so that the user only needs to have the @aws-sdk/client-cloudwatch-logs module. To do this, I had to remove the proxy option which uses the main AWS sdk. In my opinion, this project shouldn't need to touch that option anyway. I also update mocha to fix the audit issues.
Lastly, I updated the typescript definition.
namefor transport options is optional.