-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using aws-sdk v3 instead of v2 as dependency. #160
Comments
What a coincidence, I was going to raise this issue too. Yesterday, I just forked and modified for aws-sdk v3 for my own usage. You may take it as a reference. zendagin@a394491 It seems that support of v3 was considered in #144 (comment) but finally gave up. I think the point of easy migration is using v2 compatible style and use NodeHttpHandler to config proxy. (Well I spent some time to figure out the proxy config) Edit: err.code is renamed to err.name in v3, so it seems that it is not fully compatible |
Much needed! All our code is based on v3 and adding the v2 is really bloating our bundle. |
Hello, sorry for the late reply, I have little to no time now to address issues, if you would like to submit PRs I am very open to review and merge. EDIT: Is #172 addressing your needs? |
@dicky1126277766238 did you end up with some changes you'd feel comfortable to share as a PR here? I won't have time to do such a change. |
Hi @lazywithclass - will you be able to merge #172 any time soon? |
winston-cloudwatch@3.2.0 is out with this #172 merged, sorry for being so late I am full of work and uni studies. |
Currently this package uses aws-sdk v2 as dependency. Can you please look into the possibility of migrating over to v3. This will save a lot of space. The v3 is modular in nature and it will be beneficial for us to use @aws-sdk/client-cloudwatch-logs instead of v2 which imports all AWS service functions.
Please let me know if this is possible or maybe it can be scoped as part of Version 4 ? I am ready to help if you need any.
Thanks
The text was updated successfully, but these errors were encountered: