Skip to content

fix: resolve 4 CodeQL alerts - #357

Merged
laurentiu021 merged 1 commit into
mainfrom
fix/codeql-catch-all
May 14, 2026
Merged

laurentiu021 merged 1 commit into
mainfrom
fix/codeql-catch-all

Conversation

@laurentiu021

@laurentiu021 laurentiu021 commented May 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes 4 actionable CodeQL alerts in source code. Remaining 26 alerts are in generated code (obj/Release/*.g.cs) and 1 P/Invoke call (acceptable).

Alerts fixed

Remaining alerts (26)

All in generated code (RegexGenerator.g.cs, *.g.cs view files) — cannot be fixed in source.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sManager/SysManager/Services/PingMonitorService.cs 0.00% 3 Missing ⚠️
...er/SysManager/Services/TracerouteMonitorService.cs 0.00% 3 Missing ⚠️
...r/SysManager/Helpers/OutputKindToBrushConverter.cs 0.00% 2 Missing ⚠️
SysManager/SysManager/ViewModels/LogsViewModel.cs 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitai Bot commented May 14, 2026 •

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR consolidates five small defensive coding improvements: background task shutdown methods now handle specific exceptions instead of broad catch-all blocks, a boolean converter is refactored to pattern matching, a view model cast is made safe with fallback logic, and all changes are documented in the changelog.

Changes

Code Robustness Improvements

Layer / File(s) Summary
Service shutdown exception handling refinement
SysManager/SysManager/Services/PingMonitorService.cs, SysManager/SysManager/Services/TracerouteMonitorService.cs
Stop() methods in both services replace broad exception swallowing with targeted handling for AggregateException and ObjectDisposedException, with bounded timeouts (1500ms and 3000ms respectively).
Boolean converter logic refactoring
SysManager/SysManager/Helpers/OutputKindToBrushConverter.cs
BoolInverterConverter's Convert and ConvertBack methods are simplified from conditional bool checking to direct pattern matching using value is not true.
View model safe casting for collection view
SysManager/SysManager/ViewModels/LogsViewModel.cs
UpdateVisibleCount replaces an unsafe direct cast ((CollectionView)EntriesView).Count with safe as-casting and a fallback count operation via EntriesView.Cast<object>().Count().
Release notes documentation
CHANGELOG.md
New 0.48.6 release section (2026-05-14) documents fixes for both services, the boolean converter, and the view model casting improvement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Five little fixes, all snug and tight,
Exception handling done just right,
Casting safely, patterns clean,
Changelog records what was seen,
Robustness hopping toward the light! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: resolve 4 CodeQL alerts' directly and accurately describes the primary change—fixing four CodeQL security alerts across multiple files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/codeql-catch-all

Comment @coderabbitai help to get the list of available commands and usage tips.

@laurentiu021
laurentiu021 merged commit 0b650e5 into main May 14, 2026
4 of 5 checks passed
@laurentiu021
laurentiu021 deleted the fix/codeql-catch-all branch May 14, 2026 10:30
laurentiu021 added a commit that referenced this pull request May 22, 2026
…357)

## Summary

Replace 10 outdated screenshots with 18 fresh captures covering all
available tabs. The README Screenshots section now uses collapsible
`<details>` groups matching the sidebar layout, with clickable
thumbnails that open the full-size image.

## Changes

- **18 new screenshots**: Dashboard, System Health, Windows Update,
Performance, Quick Cleanup, Deep Cleanup, Disk Analyzer, Duplicates,
Ping, Traceroute, Speed Test, Network Repair, App Updates, Uninstaller,
Drivers, Battery, Logs, About
- **README.md**: Screenshots section rewritten with collapsible groups
(Dashboard open by default, rest collapsed) and width-constrained
thumbnails
- **docs/screenshots/README.md**: Updated file naming convention to
match new numbering (01–18)
- **Removed**: 10 old screenshots replaced by the new set

## Not yet captured

Startup Manager, Process Manager, and Services tabs contain sensitive
data and are excluded for now.

Closes #86

Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
laurentiu021 added a commit that referenced this pull request May 22, 2026
…stract-cast (#357)

Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants