fix: add hello-haproxy #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #231453: Update Lua example repos to use new SDK. |
cwaldren-ld
force-pushed
the
cw/release-please-publish
branch
from
a965b51 to
9056fd9
Compare
cwaldren-ld
force-pushed
the
cw/sc-231453/hello-haproxy
branch
from
76fcd9b to
b44dc4d
Compare
cwaldren-ld
force-pushed
the
cw/sc-231453/hello-haproxy
branch
from
2fe364c to
4038ab8
Compare
cwaldren-ld
force-pushed
the
cw/sc-231453/hello-haproxy
branch
from
566096c to
0872170
Compare
kinyoklion
reviewed
Feb 1, 2024
.github/workflows/ci.yml
Outdated
| # The sleep is to give haproxy some time to start-up. | ||
| run: | | ||
| docker run -dit --rm --name hello-haproxy -p 8123:8123 --env LD_SDK_KEY="$LD_SDK_KEY" launchdarkly:hello-haproxy | ||
| sleep 5 |
There was a problem hiding this comment.
This is probably fine, but if it ends up being a problem you could instead just use curl with something like --retry 10 --retry-connrefused --retry-delay 1
There was a problem hiding this comment.
That's probably more robust.
kinyoklion
approved these changes
Feb 1, 2024
cwaldren-ld
force-pushed
the
cw/sc-231453/hello-haproxy
branch
from
2c887ef to
39f3b9a
Compare
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Feb 7, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.3](v2.0.2...v2.0.3) (2024-02-07) ### Bug Fixes * add hello-haproxy ([#69](#69)) ([72481e3](72481e3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the
hello-haproxyexample directly into the repo so it can be continually tested and kept up-to-date.This is
fixbecause:release-please, but..