Skip to content

Commit 39f3b9a

Browse files
committed
readme updates
1 parent 006876b commit 39f3b9a

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,11 @@ jobs:
5252
run: |
5353
docker build -t launchdarkly:hello-haproxy -f ./examples/hello-haproxy/Dockerfile .
5454
- name: Run hello-haproxy container in background
55-
# The sleep is to give haproxy some time to start-up.
5655
run: |
5756
docker run -dit --rm --name hello-haproxy -p 8123:8123 --env LD_SDK_KEY="$LD_SDK_KEY" launchdarkly:hello-haproxy
58-
sleep 5
5957
- name: Evaluate feature flag
6058
run: |
61-
curl -s -v http://localhost:8123 | tee response.txt
59+
curl --retry 5 --retry-all-errors --retry-delay 1 -s -v http://localhost:8123 | tee response.txt
6260
grep -F "Feature flag is false for this user" response.txt || (echo "Expected false evaluation!" && exit 1)
6361
- name: Stop hello-haproxy container
6462
run: |

README.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,26 +49,29 @@ Getting started
4949
Refer to the [SDK documentation](https://docs.launchdarkly.com/sdk/server-side/lua#getting-started) for instructions on
5050
getting started with using the SDK.
5151

52-
Runnable examples in this repo are available:
52+
The following examples are available in addition to the usage guide linked above:
53+
5354

5455
| Example | Purpose |
5556
|-------------------------------------------------|-----------------------------------------------------------------------------------------------|
5657
| [hello-lua-server](./examples/hello-lua-server) | Demonstrates basic example of Lua SDK usage from the command line. |
5758
| [hello-haproxy](./examples/hello-haproxy) | Demonstrates usage of the Lua SDK as a [HAproxy](https://www.haproxy.org/) module via Docker. |
5859

5960

61+
Before you start using the SDK, you'll need to install it.
62+
6063
There are two paths to installing the SDK. In both cases, you must first install the native
6164
[LaunchDarkly C++ Server-side SDK](https://github.com/launchdarkly/cpp-sdks).
6265

6366
You may build the C++ SDK from source using [CMake](https://cmake.org/), or obtain pre-built artifacts from the
6467
[releases page](https://github.com/launchdarkly/cpp-sdks/releases?q=%22launchdarkly-cpp-server%22). Ensure you install
65-
the correct variant (with or without Redis support) as necessary.
68+
the correct variant (with or without Redis support) as defined by your requirements.
6669

6770
Please note that the Lua SDK uses the C++ server-side SDK's C bindings, so if you're using prebuilt artifacts
6871
then only a C99 compiler is necessary. See the [Build Requirements](https://github.com/launchdarkly/cpp-sdks#build-requirements).
6972

7073

71-
Then, install the [LuaRocks](https://github.com/luarocks/luarocks/wiki/Download) package manager.
74+
Once the C++ SDK is available, install the [LuaRocks](https://github.com/luarocks/luarocks/wiki/Download) package manager.
7275

7376
### Install via `luarocks install`
7477

@@ -89,7 +92,7 @@ LDREDIS_DIR=./path-to-cpp-sdk-with-redis-support-installation
8992

9093
### Install via `luarocks make`
9194

92-
If you don't want to install from LuaRocks, it's possible to compile the modules locally using `luarocks make`.
95+
If you don't want to install from LuaRocks, it's possible to compile the modules locally in this git repo by using `luarocks make`.
9396

9497
**Install the base SDK only**
9598
```bash
@@ -111,7 +114,7 @@ Read our [documentation](https://docs.launchdarkly.com) for in-depth instruction
111114
Testing
112115
-------
113116

114-
We run integration tests for all our SDKs using a centralized test harness. This approach gives us the ability to test for consistency across SDKs, as well as test networking behavior in a long-running application. These tests cover each method in the SDK, and verify that event sending, flag evaluation, stream reconnection, and other aspects of the SDK all behave correctly.
117+
We run integration tests for all our SDKs using a centralized test harness. This approach gives us the ability to test for consistency across SDKs. These tests cover each method in the SDK, and verify that event sending, flag evaluation, stream reconnection, and other aspects of the SDK all behave correctly.
115118

116119
Contributing
117120
------------

0 commit comments

Comments
 (0)