Skip to content

Conversation

@barryvdh
Copy link
Contributor

@barryvdh barryvdh commented Aug 19, 2019

This is a Draft Pull Request to check if this is worth including, before too much time is spent on this.

  • Adds timing information to entries
  • Shows timing information
  • Ability to start/stop timers

Fixes #674

Example:
Screen Shot 2019-08-15 at 22 19 56

TODO

  • Fix layout to make it useful
  • Think about how to add timing (eg. sections? perhaps use https://symfony.com/doc/current/components/stopwatch.html ? )
  • Record the timing data together with the IncomingEntry, or create 1 timing entry with just all the events?
  • Add timing info for all appropriate watchers.
  • Add framework timing info (boot etc)

cc @christophmayrhofer

@barryvdh
Copy link
Contributor Author

@taylorotwell Do you think this is worth considering?

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@taylorotwell
Copy link
Member

Better to use something more robust like Blackfire, imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Measuring Tool / Timeline

3 participants