Add default fallbacks #57
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
commented
Aug 31, 2023
| protected function configureDefaultFallback(): void | ||
| { | ||
| self::fallbackUsing(fn (self $prompt) => $this->retryUntilValid( | ||
| fn () => (new SymfonyStyle(new ArrayInput([]), static::output()))->confirm($prompt->label, $prompt->default), |
There was a problem hiding this comment.
We'd need to call the setInteractive method on the Input object to respect the --no-interaction option.
Implementing a first-party "non-interactive" feature in Prompts is probably worthwhile so we can return an appropriate value where possible and ensure that any required and validate arguments would pass regardless of the fallback configuration.
Symfony's choice component, for example, does not allow you to select no option but will return null in non-interactive mode.
|
I don't know it is right or wrong for all?
But it's need the all has installed the |
This was referenced Sep 8, 2023
jessarcher
force-pushed
the
fallbacks
branch
from
d21f1c5 to
3863588
Compare
jessarcher
force-pushed
the
fallbacks
branch
from
3863588 to
705773c
Compare
This was referenced Sep 20, 2023
|
Will revisit this later |
|
okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds default fallback behavior directly to the Prompts library so that it doesn't need to be implemented by consuming projects and packages.
This will allow us to remove this code from the Laravel installer.
We could also remove the same code from
laravel/framework, however, the framework fallback currently uses the updated styling from Nuno.