Use prompts non-interactive mode instead of Symfony fallbacks #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can wait until Prompts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Laravel installer to use Prompts' new "non-interactive mode" instead of relying on the Symfony fallback.
This does not change the behaviour when using the
-nargument, as the command will never call theinteracthook, which is the only place we currently use Prompts in the installer. It only changes the output when there are missing required arguments and the input is not a TTY (such as in CI).This change is pretty insignificant for the installer, but it paves the way for laravel/prompts#57, allowing us to remove the fallback code from this repo and any other packages/projects that can't or don't rely on
laravel/frameworkto configure a Windows fallback.