Skip to content

enhance the Database/Builder aggregate function to deal with group by sql. #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

enhance the Database/Builder aggregate function to deal with group by sql. #7372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f90b3dd
Update Builder.php
fcjailybo Feb 10, 2015
1ef941a
Merge pull request #1 from fcjailybo/fcjailybo-patch-1
fcjailybo Feb 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Illuminate/Database/Query/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1693,6 +1693,13 @@ public function aggregate($function, $columns = array('*'))

$this->columns = $previousColumns;

// Once we have used orderBy function,$result may have more than one record,
//and $results[0] is just the first group count,so we need to get the count
//of $results's elements.
if (count($results) > 1) {
return count($results);
}

if (isset($results[0]))
{
$result = array_change_key_case((array) $results[0]);
Expand Down