enhance the Database/Builder aggregate function to deal with group by sql. #7372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once we have used orderBy function,$result may have more than one record, and $results[0] is just the first group count,so we need to get the count of $results's elements.
Update Builder.php
fcjailybo
changed the title
|
This is actually really clever, if it works correctly. Why did you close this? |
|
@fcjailybo This would be good to have merged into 5.1. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enhance the Database/Builder class.
Once we have used orderBy function,$result may have more than one record,and $results[0] is just the first group count,so we need to get the count of $results's elements.