[12.x] Fixing MemoizedStore with Redis Cluster #57828
Merged
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimonus
changed the title
vadimonus
added a commit
to vadimonus/laravel-framework
that referenced
this pull request
Nov 20, 2025
taylorotwell
added a commit
to illuminate/cache
that referenced
this pull request
Nov 20, 2025
…tion (#57837) * [12.x] mark certain tests skipped in RedisStoreTest * [12.x] flushStaleEntries for PhpRedisCluster in RedisTagSet * [12.x] unskip test for many (fixed in laravel/framework#57828) * Update RedisTagSet.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split from of #57714
MemoizedStoreTest was skipped in #57710, it was failing with RedisCluster, because such commands as FlushAll and FlushDb should be called on each node separately.
Laravel already has implementation for flushDb over all nodes in cluster. So just replacing flushAll with flushing databases used in test to unskip it.
After that test failed on PredisClusterConnection (see https://github.com/laravel/framework/actions/runs/19509599522/job/55845498143)
That's because MemoizedStore relies heavily on
manymethod, that do not work on PredisCluster, if keys hashes to different slots. PHPRedis mget implementation works well even if key hashes differs.So, i replicated solution from #53940 , but only for PredisCluster.