[12.x] Fixing RedisTaggedCache::flushStale with PhpRedisClusterConnection (#57837)

* [12.x] mark certain tests skipped in RedisStoreTest

* [12.x] flushStaleEntries for PhpRedisCluster in RedisTagSet

* [12.x] unskip test for many (fixed in #57828)

* Update RedisTagSet.php

---------

Co-authored-by: Taylor Otwell <taylor@laravel.com>

Author: vadimonus

src/Illuminate/Cache/RedisTagSet.php

@@ -79,11 +79,19 @@ public function entries()
      */
     public function flushStaleEntries()
     {
-        $this->store->connection()->pipeline(function ($pipe) {
+        $flushStaleEntries = function ($pipe) {
             foreach ($this->tagIds() as $tagKey) {
                 $pipe->zremrangebyscore($this->store->getPrefix().$tagKey, 0, Carbon::now()->getTimestamp());
             }
-        });
+        };
+
+        $connection = $this->store->connection();
+
+        if ($connection instanceof PhpRedisConnection) {
+            $flushStaleEntries($connection);
+        } else {
+            $connection->pipeline($flushStaleEntries);
+        }
     }
 
     /**

tests/Integration/Cache/RedisStoreTest.php

@@ -8,7 +8,6 @@
 use Illuminate\Redis\Connections\PhpRedisClusterConnection;
 use Illuminate\Redis\Connections\PredisClusterConnection;
 use Illuminate\Support\Facades\Cache;
-use Illuminate\Support\Facades\Redis;
 use Illuminate\Support\Sleep;
 use Mockery as m;
 use Orchestra\Testbench\TestCase;
@@ -23,12 +22,6 @@ protected function setUp(): void
     {
         $this->afterApplicationCreated(function () {
             $this->setUpRedis();
-
-            $connection = $this->app['redis']->connection();
-            $this->markTestSkippedWhen(
-                $connection instanceof PhpRedisClusterConnection || $connection instanceof PredisClusterConnection,
-                'RedisStore currently does not support tags, many and some other on Redis Cluster cluster connections',
-            );
         });
 
         $this->beforeApplicationDestroyed(function () {
@@ -103,6 +96,8 @@ public function testItCanExpireWithZeroTTL()
 
     public function testTagsCanBeAccessed()
     {
+        $this->markTestSkippedWithPredisClusterConnection();
+
         Cache::store('redis')->clear();
 
         Cache::store('redis')->tags(['people', 'author'])->put('name', 'Sally', 5);
@@ -119,6 +114,8 @@ public function testTagsCanBeAccessed()
 
     public function testTagEntriesCanBeStoredForever()
     {
+        $this->markTestSkippedWithPredisClusterConnection();
+
         Cache::store('redis')->clear();
 
         Cache::store('redis')->tags(['people', 'author'])->forever('name', 'Sally');
@@ -151,6 +148,8 @@ public function testTagEntriesCanBeIncremented()
 
     public function testIncrementedTagEntriesProperlyTurnStale()
     {
+        $this->markTestSkippedWithPredisClusterConnection();
+
         Cache::store('redis')->clear();
 
         Cache::store('redis')->tags(['votes'])->add('person-1', 0, $seconds = 1);
@@ -167,6 +166,8 @@ public function testIncrementedTagEntriesProperlyTurnStale()
 
     public function testPastTtlTagEntriesAreNotAdded()
     {
+        $this->markTestSkippedWithPredisClusterConnection();
+
         Cache::store('redis')->clear();
 
         Cache::store('redis')->tags(['votes'])->add('person-1', 0, new DateTime('yesterday'));
@@ -180,6 +181,8 @@ public function testPastTtlTagEntriesAreNotAdded()
 
     public function testPutPastTtlTagEntriesProperlyTurnStale()
     {
+        $this->markTestSkippedWithPredisClusterConnection();
+
         Cache::store('redis')->clear();
 
         Cache::store('redis')->tags(['votes'])->put('person-1', 0, new DateTime('yesterday'));
@@ -191,6 +194,8 @@ public function testPutPastTtlTagEntriesProperlyTurnStale()
 
     public function testTagsCanBeFlushedBySingleKey()
     {
+        $this->markTestSkippedWithPredisClusterConnection();
+
         Cache::store('redis')->clear();
 
         Cache::store('redis')->tags(['people', 'author'])->put('person-1', 'Sally', 5);
@@ -207,6 +212,8 @@ public function testTagsCanBeFlushedBySingleKey()
 
     public function testStaleEntriesCanBeFlushed()
     {
+        $this->markTestSkippedWithPredisClusterConnection();
+
         Cache::store('redis')->clear();
 
         Cache::store('redis')->tags(['people', 'author'])->put('person-1', 'Sally', 1);
@@ -277,6 +284,8 @@ public function testIncrementWithSerializationEnabled()
 
     public function testTagsCanBeFlushedWithLargeNumberOfKeys()
     {
+        $this->markTestSkippedWithPredisClusterConnection();
+
         Cache::store('redis')->clear();
 
         $tags = ['large-test-'.time()];
@@ -298,4 +307,12 @@ public function testTagsCanBeFlushedWithLargeNumberOfKeys()
         $keyCount = Cache::store('redis')->connection()->keys('*');
         $this->assertCount(0, $keyCount);
     }
+
+    protected function markTestSkippedWithPredisClusterConnection()
+    {
+        $this->markTestSkippedWhen(
+            $this->app['redis']->connection() instanceof PredisClusterConnection,
+            'This test currently fails on Predis Cluster connection',
+        );
+    }
 }