[11.x] Fix regression bug with global Factory::guessModelNamesUsing()
#54665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug introduced via #54644 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
commented
Feb 18, 2025
| @@ -838,12 +839,15 @@ public function test_factory_model_names_correct() | |||
|
|
|||
| public function test_factory_global_model_resolver() | |||
| { | |||
| \Illuminate\Database\Eloquent\Factories\Factory::guessModelNamesUsing(function ($model) { | |||
There was a problem hiding this comment.
$model here is an instance of Illuminate\Database\Eloquent\Factories\Factory and not a string as indicated in the test (return). If the code was executed this would have thrown an error instead of passing the test.
2 tasks
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug introduced via #54644