Handle the renamed static property in Factory
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
reviewed
Feb 20, 2025
Laravel recently changed `Factory::$modelNameResolver` to `Factory::$modelNameResolvers`
samlev
force-pushed
the
bugfix/Laravel_11.43
branch
from
ca94000 to
83e7556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel recently changed
Factory::$modelNameResolvertoFactory::$modelNameResolversin PR #54644.This has made me slightly annoyed because it's broken my test suite.
I've opened an issue mentioning that it's a BC break, I'm guessing that the answer from Laravel will be "why are you touching internal properties?".
Either way, this PR updates the Factory helper to circumvent the bug.