[11.x] Add precision support to Number::currency() #54360
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number::format()has this functionality.Number::percentage()also has this functionality.fileSize,abbreviate,forHumans,summarizealso has this functionality.It makes no sense not to add this option for the
currencymethod.There are times when you don't want to force your application to spit out currencies with 2 decimals - sometimes you want to work with either more or less. This PR does just that.
We've had this issue in our project, where we needed to format a bunch of numbers, percentages and currencies - however, only the first two could be done with precision, so we had to reinvent the wheel, and make our own
currencyhelper.Consistency is key, if every method can use precision, the
currencymethod should also be able to have this feature. Let us do it the Laravel way, don't force us to make dumb workarounds.