[10.x] add digits to Number::currency()
#49550
Conversation
| * @return string|false | ||
| */ | ||
| public static function currency(int|float $number, string $in = 'USD', ?string $locale = null) | ||
| public static function currency(int|float $number, string $in = 'USD', ?string $locale = null, int $digits = null) |
There was a problem hiding this comment.
https://en.wikipedia.org/wiki/Fraction
Feel like $fractions would be better than $digits
There was a problem hiding this comment.
PHP has both fraction and digits in their naming convention (NumberFormatter::FRACTION_DIGITS) but I felt that simple number of $digits after the decimal was fine.
I can change it however we want though.
There was a problem hiding this comment.
Maybe follow the other functions and use $precision?
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions! If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response. |
4 participants
This PR adds digits to the
Number::currency()call to allow for better rounding.