Make dropForeignIdFor method complementary to foreignIdFor
#54102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dropForeignIdFormethod was originally introduced in #40950. As stated in that PR, it was intended to be the counterpart to theforeignIdFormethod. However, the actual implementation attempts to drop a foreign key, whichforeignIdFordoes not add by default. It also does not drop the column thatforeignIdForadds by default.This issue was reported in #43753 and a fix was attempted in #45134, but it did not pass tests.
I am not sure if this should be considered a true bug fix since it could potentially be a breaking change, so I have targeted
master.This PR changes
dropForeignIdForto only drop the column instead of only dropping the foreign key. The existingdropConstrainedForeignIdFormethod should be used to drop both the foreign key and column. The tests have been updated accordingly.