fix : dropForeignIdFor method in Blueprint.php

[anilkumarthakur60]

577b84d

    public function dropForeignIdFor($model, $column = null)
    {
        if (is_string($model)) {
            $model = new $model;
        }

         $this->dropForeign([$column ?: $model->getForeignKey()]);
        return  $this->dropColumn($column ?: $model->getForeignKey());
    }

previously while adding new migation for existing table that reference some other table in the drop section of migration it only drops the key constrained but not column so each time to drop the column i have to add

    public function up(): void
    {
        Schema::table('tableName', function (Blueprint $table) {
         
            $table->foreignIdFor(\App\Models\User::class)->constrained();
           
        });
    }


    public function down(): void
    {
        Schema::table('tableName', function (Blueprint $table) {
            $table->dropForeignIdFor(\App\Models\User::class);
           $table->dropColumn(['user_id']);


            //
        });
    }

this only drops the key constrained not column so to overcome this issue
i have pf with changes in #577b84d

[ankurk91]

Please link to the original issue in PR description.

[anilkumarthakur60]

i have updated in description please recheck

[ankurk91]

@anilkumarthakur60 There are failing tests, you may want to update them as well.
https://github.com/laravel/framework/actions/runs/3571042594/jobs/6002566923

[driesvints]

Seems this breaks the test suite. Please resubmit this with passing tests.

[rodrigopedra]

Isn't Blueprint@dropConstrainedForeignIdFor already there to cover this case?