[9.x] Update Encrypter.php #42370
Merged
[9.x] Update Encrypter.php #42370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enforce decrypt payload to string, fix for below error `base64_decode(): Passing null to parameter laravel#1 ($string) of type string is deprecated in vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php on line 208`
Collaborator
|
Not passing a string is not a valid way to call this function. One should expect it to crash if you pass null. |
taylorotwell
added a commit
that referenced
this pull request
May 12, 2022
This reverts commit eb5d3dd.
taylorotwell
added a commit
that referenced
this pull request
May 12, 2022
Contributor
Author
null value never crashes only keep logging PHP 8.1 I will advise conversion of
|
diadal
added a commit
to diadal/framework
that referenced
this pull request
May 26, 2022
This reverts commit 016b0c1.
Contributor
Author
you can check with PHP 8.0 with no logging but PHP 8.1 keep logging without crashes and is not a bad idea to convert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforce decrypt payload to string, fix for below error
base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated in vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php on line 208