Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Allow PSR Log v3 #40082

Closed
wants to merge 1 commit into from
Closed

[8.x] Allow PSR Log v3 #40082

wants to merge 1 commit into from

Conversation

driesvints
Copy link
Member

No description provided.

driesvints referenced this pull request Dec 16, 2021
@driesvints
Update composer.json
8dde758
GrahamCampbell
GrahamCampbell requested changes Dec 17, 2021
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge this into Laravel 8 because symfony/http-kernel 5.4.1 requires ^1.0 || ^2.0. We instead need to target this at Laravel 9.

@driesvints driesvints changed the title Allow PSR Log v3 [8.x] Allow PSR Log v3 Dec 17, 2021
@driesvints
Copy link
Member Author

psr/log v3 adds return types to its interface. We'll need to target this to master instead.

@driesvints driesvints closed this Dec 17, 2021
@driesvints driesvints deleted the psr-log-v3 branch December 17, 2021 07:42
@driesvints
Copy link
Member Author

#40087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driesvints @GrahamCampbell