[9.x] PSR Log v3 #40087
Merged
[9.x] PSR Log v3 #40087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
commented
Dec 17, 2021
| @@ -262,7 +262,7 @@ protected function formatMessage($message) | |||
| return var_export($message->toArray(), true); | |||
| } | |||
|
|
|||
| return $message; | |||
| return (string) $message; | |||
There was a problem hiding this comment.
I added this because fireLogEvent always expects the $message to be a string. And also because we pipe the message to a decorated psr/log implementation which in turn expects either a string or a Stringable.
|
It is not necessary to add the typehints. We can still support v3 without them. |
|
@GrahamCampbell can you pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
psr/logto v3. Because of the introduction of type-hints for the method arguments we'll need to explicitly add the types that we support as well to widen the method signature.