[9.x] Add missing giveConfig method in ContextualBindingBuilder #38925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniscoorn-paqt
changed the title
denniscoorn-paqt
force-pushed
the
give-config-method-contextual-binding-builder
branch
from
a1ccbbd to
42d0972
Compare
|
As @driesvints said in #36361 (comment) , and I agree:
The documentation could be updated instead to show how to bind primitives without using the |
|
See above. |
|
Yeah, I saw the comment about it being classified as syntactical sugar, but I thought it was worth the shot because of the discrepancy between implementation and contract in relation to how it is being described in the documentation. Fair enough though ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the method
giveConfigto theContextualBindingBuildercontract. A similar PR, #36361, was targeted at8.xand rejected because it would introduce a breaking change for any implementation implementing this contract. That's why this PR is targeted atmasterto make it available for the upcoming9.xrelease.One of the reasons why I think this method should be part of the contract is that the
ContextualBindingBuildercontract interface is declared as return type by the methodContainer::when(). When someone uses the "Binding primitives" example from the docs, where the existence of thegiveConfigmethod is documented, they may encounter warnings from their IDE claiming that the method doesn't exists.In my opinion this is small fix that can prevent possible confusion and improves developer experience.